Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations ......................................................................
Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7380/8/be/src/util/metrics.h File be/src/util/metrics.h: PS8, Line 249: /// The metrics to be summed. metric to be negated PS8, Line 391: MakeTMetricDef not your change, but this could use a comment. Would you mind adding one while you're here? -- To view, visit http://gerrit.cloudera.org:8080/7380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
