Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool reservations ......................................................................
Patch Set 6: (2 comments) > So just to recap, does it work as the immediate solution if I: > * Convert all the memory metrics to IntGauge > * Leave the unused reservation metric as it is in the current patch > * Create a derived metric for the MemTracker's use that simply > negates the unused reservation metric. > * Remove the negation logic from MemTracker Yeah that sounds good to me. Thanks for entertaining my brainstorming. http://gerrit.cloudera.org:8080/#/c/7380/6//COMMIT_MSG Commit Message: > I don't think it's indicative of a problem if it's large. I don't think the Thanks. Mostafa's example in IMPALA-5158 seems like a reasonable one; the gap is pretty noticeable there. I wouldn't be surprised if people also asked less insightful questions, but questions that arise from the info we put in front of them: Why is there a large 'Unused Reservation'? Does that mean Impala isn't using memory efficiently? Even if these aren't good questions or actionable, we'll probably get them. I guess we'll just iterate on this as we get more feedback (per Dan's comment). PS6, Line 29: -8.25 MB > Yeah it wouldn't show up on /metrics. Or I could just add a derived metric Ok, that works for me. I do think it'd be better if we don't have to have more special logic in mem-tracker around consumption metrics. -- To view, visit http://gerrit.cloudera.org:8080/7380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1fa3110dc893321f9f4e8ced6b7ede12194dad Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
