Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7706/1/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: Line 681: List<Expr> slotRefs = Lists.newArrayList(); > Might be easier/shorter: Done Line 690: // Inequality correlated predicates are not currently supported in aggregate > This bug is not specific to inequality predicates. I think it's really that Done Line 691: // subqueries (see IMPALA-5531). > We should be able to run queries with arbitrary correlated predicates if th Done Line 692: if (expr instanceof BinaryPredicate && !correlatedPredicates.isEmpty() && > Let's report which predicate makes the subquery unsupported. I am not sure the BinaryPredicate check is redundant. The first is applied on 'expr' which is the subquery expr while the latter is applied on the correlated predicates. Is this what you mean? -- To view, visit http://gerrit.cloudera.org:8080/7706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca7b60ef0543430d2f5a802285254ebb52db2ab Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
