Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7706/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: Line 1417: public static String toSqlHelper(List<Expr> exprs) { > listToSql()? Done http://gerrit.cloudera.org:8080/#/c/7706/3/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: Line 399: // Ensure that all the extracted correlated predicates can be added to the on-clause > nit: we usually use caps for clauses and such, i.e. ON-clause Done Line 648: private static void canRewriteCorrelatedSubquery(Expr expr) throws AnalysisException { > validateCorrelatedSubqueryStmt()? Done Line 676: * added to the on-clause of the join that results from the subquert rewrite; It throws > ON-clause and typo: subquery. Also use "." instead of ";" Done Line 683: Preconditions.checkNotNull(correlatedPredicates); > Preconditions.checkState(inlineView.isAnalyzed()); Done -- To view, visit http://gerrit.cloudera.org:8080/7706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca7b60ef0543430d2f5a802285254ebb52db2ab Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
