Dan Hecht has posted comments on this change. Change subject: IMPALA-3208: max_row_size option ......................................................................
Patch Set 13: > It doesn't seem too necessary to increase max_row_size > automatically. The default will fit 32k 16-byte columns, which > seems like a lot. It may also be tricky to choose a reasonable > value if there are any var-len columns, since we'd need to include > some room for var-len values. I was actually suggesting to effectively decrease max_row_size when there is no var-len data. i.e. why bother paying the reservation cost when we know it's not needed? I'm fine with doing that as a follow on or not at all if you dont feel it's worth it. -- To view, visit http://gerrit.cloudera.org:8080/7629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70f6dddbcef124bb4b329ffa2e42a74a1826570 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
