Tim Armstrong has posted comments on this change. Change subject: IMPALA-3208: max_row_size option ......................................................................
Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/7629/14//COMMIT_MSG Commit Message: Line 26: per read and write iterator, and temporarily requires reservation > Is this temporary reservation instead of or in addition to the default-size Yeah if the max row size is larger than the buffer size, then we need 2 of the reserved buffers to be larger. http://gerrit.cloudera.org:8080/#/c/7629/14/testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test File testdata/workloads/functional-planner/queries/PlannerTest/max-row-size.test: Line 21: 02:HASH JOIN [INNER JOIN, BROADCAST] > We may eventually want to create a simpler test framework for resource plan Yeah that makes sense, only a subset of the values are interesting for this test. -- To view, visit http://gerrit.cloudera.org:8080/7629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70f6dddbcef124bb4b329ffa2e42a74a1826570 Gerrit-PatchSet: 14 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
