Dan Hecht has posted comments on this change.

Change subject: IMPALA-5713: always reserve memory for preaggs
......................................................................


Patch Set 2:

> I'm not 100% confident this is the optimal thing to do, but it
 > avoids the possibility of some pretty bad perf regressions in
 > memory-constrained scenarios.

Before buffer-pool, when under memory pressure, was it not possible to also get 
into a pass-through-everything mode?

-- 
To view, visit http://gerrit.cloudera.org:8080/7739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b544f9ec1a906719e2bbb074743926b95a3a573
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to