Tim Armstrong has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs ......................................................................
Patch Set 2: With the old code, it could essentially always allocate the small buffers and hash tables because those didn't require a reservation. Those helps a lot if there's a relatively small number of groups. -- To view, visit http://gerrit.cloudera.org:8080/7739 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b544f9ec1a906719e2bbb074743926b95a3a573 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
