Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7560/8/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: PS8, Line 200: if (!Table.isExternalTable(msTbl)) { : fail("Failed to add table, external kudu table expected:\n" + createTableSql); : } My concern with this approach is that this now does depend on Kudu, and I'm not sure we have to. Is there a reason not to make this work for managed Kudu tables, and just set the KuduTable.primaryKeyColumnNames_ from the stmt.getKuduPartitionParams()? Then I think this doesn't require calling into Kudu. Also it's less restrictive than only supporting Kudu tables that already exist. -- To view, visit http://gerrit.cloudera.org:8080/7560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
