Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables ......................................................................
Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/7560/8/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: PS8, Line 200: fail("Failed to add table, external kudu table expected:\n" + createTableSql); : } : t > This wont work for managed kudu tables because this method requires we only Right, makes sense. Yeah, so we're already tied to Kudu in planner tests. I guess this is the downside of not keeping this metadata in the catalog. I agree then it's not worth trying to address here. I'm fine with this approach if Alex is as well. http://gerrit.cloudera.org:8080/#/c/7560/10/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: PS10, Line 170: but no : * other metadata This isn't true, for HDFS tables we set the partition map (to the 'default partition'). It might just be easier and more clear to say: Add a new dummy table to the catalog based on the given CREATE TABLE sql. The returned table only has its metadata partially set, but is capable of being planned. I'd be curious to hear what Alex thinks. -- To view, visit http://gerrit.cloudera.org:8080/7560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
