Tim Armstrong has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/disable-unsafe-spills.test File testdata/workloads/functional-query/queries/QueryTest/disable-unsafe-spills.test: Line 5: set disable_unsafe_spills=true; > is there a similar test w/ SCRATCH_LIMIT set to 0 and maybe another non-zer Yep, test_scratch_limit. I made some notes in IMPALA-5622 about the coverage in this area. http://gerrit.cloudera.org:8080/#/c/7787/1/tests/query_test/test_spilling.py File tests/query_test/test_spilling.py: Line 67: self.run_test_case('QueryTest/disable-unsafe-spills', vector) > can this just go in test_spilling? I don't think we'll need to add more tes I've been tending to split out the tests into separate files when there's some kind of logical grouping because a lot of them take a while to run - it's a pain to run the whole test file when you only want to run one of the tests. -- To view, visit http://gerrit.cloudera.org:8080/7787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
