Tim Armstrong has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test File testdata/workloads/functional-query/queries/QueryTest/spilling-sorts-exhaustive.test: Line 197: # Test that we can spill with a buffer size larger than the default I/O size (8mb). > worth writing a similar test for join/agg? I'm not sure if it's that interesting. My initial motivation for this was just to make sure that there are no assumptions in TmpFileMgr or DiskIoMgr about the size of the reads and writes. -- To view, visit http://gerrit.cloudera.org:8080/7787 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03de00394bb6bbcf381250f816e22a4b987f1135 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
