Alex Behm has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7783/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 131: // overhead of MemPools, RowBatches, etc. This is only used if there is no data being You say this is only used if there is no data being scanned, but I don't see that reflected in the code below (the max() is applied irrespective of the value of perHostScanRanges). Fix code or adjust comment. Line 136: private static final long MIN_MEMORY_ESTIMATE = 1 * 1024 * 1024; final static (for consistency) Line 1046: if ((slot.getColumn() == null || How about this instead: if (!slot.isMaterialized() || slot == countStarSlot_) continue; -- To view, visit http://gerrit.cloudera.org:8080/7783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf5c2316bef2afae54a94245c715534ed294f286 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
