Alex Behm has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression ......................................................................
Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7783/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 136: private final HdfsTable tbl_; > I'd never noticed that we used the other way. "final static" sounds wrong t Thanks. I tend to prefer static final as well. Let's leave as since it's now at least consistent within the file. http://gerrit.cloudera.org:8080/#/c/7783/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 1044: if (!slot.isMaterialized() || slot == countStarSlot_) continue; No other planner tests changed? -- To view, visit http://gerrit.cloudera.org:8080/7783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf5c2316bef2afae54a94245c715534ed294f286 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
