Tim Armstrong has posted comments on this change. Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7809/1/testdata/workloads/functional-query/queries/QueryTest/spilling-query-options.test File testdata/workloads/functional-query/queries/QueryTest/spilling-query-options.test: PS1, Line 27: ure tha > what about the other phases? Yeah I guess we should test GETNEXT too. I don't think the other phases (CLOSE, etc) are relevant. Applying the debug action post-open won't force spilling but forces passthrough in the preaggregation. I also ran into a problem with the query option resetting logic where it didn't quote the strings when setting the option back to the empty string. -- To view, visit http://gerrit.cloudera.org:8080/7809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b55b2dee0779b1739af5d75943518ec40d6ce Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
