Michael Brown has posted comments on this change. Change subject: IMPALA-5830: SET_DENY_RESERVATION_PROBABILITY test ......................................................................
Patch Set 2: (3 comments) Mostly naming/commenting nits. http://gerrit.cloudera.org:8080/#/c/7809/2/tests/query_test/test_spilling.py File tests/query_test/test_spilling.py: PS2, Line 33: TestSpilling Does it make sense to call this TestSpillingDebugActionDimensions ? Or, consider adding a comment here that's similar to L72. PS2, Line 71: TestSpillingNoDebugAction Maybe append Dimensions to this name? At least one test uses debug actions, just using query options. PS2, Line 95: setting debug_action to alternative values Maybe append the comment "via query options". -- To view, visit http://gerrit.cloudera.org:8080/7809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida6b55b2dee0779b1739af5d75943518ec40d6ce Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
