John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer ......................................................................
Patch Set 8: (1 comment) Thanks for the feedback Henry. I've attempted to create an effective test. http://gerrit.cloudera.org:8080/#/c/7061/8/be/src/rpc/thrift-server-test.cc File be/src/rpc/thrift-server-test.cc: Line 439: EXPECT_TRUE(did_reach_max); Not sure if this will be effective. Could end up being racy? If so probably extremely rare? -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Sherman <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: John Sherman <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
