Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer ...................................................................... Patch Set 9: (1 comment) Yes, a run of the gerrit-verify-dryrun-external is a good idea. If that passes, we can +2 this patch and merge it. I just have one nit review about a code comment otherwise. http://gerrit.cloudera.org:8080/#/c/7061/9/be/src/transport/TSaslServerTransport.cpp File be/src/transport/TSaslServerTransport.cpp: http://gerrit.cloudera.org:8080/#/c/7061/9/be/src/transport/TSaslServerTransport.cpp@162 PS9, Line 162: // It would be possible for the transport to be created multiple times if this method : // was called concurrently on the same 'trans' object. The current usage of this : // method is that it is always called serially. Instead of saying it's always called serially, I think this comment is clearer: "This method should never be called concurrently with the same 'trans' object. Therefore, it is safe to drop the transportMap_mutex_ here." -- To view, visit http://gerrit.cloudera.org:8080/7061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255 Gerrit-Change-Number: 7061 Gerrit-PatchSet: 9 Gerrit-Owner: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@arcadiadata.com> Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Oct 2017 00:09:49 +0000 Gerrit-HasComments: Yes
