Tim Armstrong has posted comments on this change. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() ......................................................................
Patch Set 1: (2 comments) Looks good to me, only a couple of minor comments. http://gerrit.cloudera.org:8080/#/c/7849/1/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: Line 280: /// 'build_filters' is true, runtime filters are populated. Can you add a short description of the parameter? PS1, Line 477: is_null_partition nit: parameter name doesn't match other functions -- To view, visit http://gerrit.cloudera.org:8080/7849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06acbebc9d2d23bef4734b480a5d3ce41680ea70 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
