Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() ......................................................................
IMPALA-3897 Codegen null-aware constant in PHJ::ProcessBuildBatch() This change codegen outs a branch in ProcessBuildBatch(). This branch never gets executed for most of the join types except NULL_AWARE_LEFT_ANTI_JOIN. The branch itself is not expensive to execute, but it will reduce codegen time by removing the dead code inside the branch for almost all join modes. Change-Id: I06acbebc9d2d23bef4734b480a5d3ce41680ea70 Reviewed-on: http://gerrit.cloudera.org:8080/7849 Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/codegen/gen_ir_descriptions.py M be/src/exec/partitioned-hash-join-builder-ir.cc M be/src/exec/partitioned-hash-join-builder.cc M be/src/exec/partitioned-hash-join-builder.h 4 files changed, 20 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7849 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06acbebc9d2d23bef4734b480a5d3ce41680ea70 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]>
