Dan Hecht has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/3/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: Line 96: local_backend_descriptor_.__set_krpc_svc_address(krpc_svc_addr); > Is your question why it has to be saved to the local backend descriptor? Or Oh, I was confused by all the different places and ways we set the port and how we were doing that for thrift since it gets carried around differently. The more we can make things consistent, and have less redundant state too (i.e. both flags and ExecEnv fields), the better. -- To view, visit http://gerrit.cloudera.org:8080/7760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
