Henry Robinson has posted comments on this change. Change subject: IMPALA-4856: Include KRPC services in plan fragment's destinations ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: PS2, Line 172: DCHECK_GT(FLAGS_krpc_port, 0); > As far as I understand, the only other user of this constructor (other than I think it would be better to keep things as they are. There aren't that many FLAGS_*_port accesses - the main ones I see are from catalog-op-executor.cc and they could be replaced with a call to ExecEnv::catalog_service_port(). That's the point of the ExecEnv, as I understand it. I would rather we eventually remove the default c'tor of ExecEnv, honestly. Anyhow, I'm just suggesting you add a TODO; we don't need to make a decision right now. -- To view, visit http://gerrit.cloudera.org:8080/7760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
