Lars Volker has posted comments on this change. Change subject: IMPALA-4826 Fix wrong scan result on repeated root schema in Parquet. ......................................................................
Patch Set 1: (3 comments) Looks good to me, only minor comments http://gerrit.cloudera.org:8080/#/c/7870/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4826 Fix wrong scan result on repeated root schema in Parquet. nit: Colon after JIRA Line 9: Having the repetition level set to REPEATED on the root schema Can you explain why it should be ignored, i.e. include a reference to the parquet format? http://gerrit.cloudera.org:8080/#/c/7870/1/testdata/data/README File testdata/data/README: Line 111: Generated by hacking Impala's Parquet writer. I'm not very happy with us collecting more and more specially crafted files without a way to repro them. Can you push the hack to somewhere, e.g. your public Github, and mention the link here. That way we have a chance of preserving the information. What do others think? -- To view, visit http://gerrit.cloudera.org:8080/7870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea84589e1d122ad9d43adde46893ec0ecc5f9c4 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
