Gabor Kaszab has posted comments on this change. Change subject: IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7870/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4826: Fix wrong scan result on repeated root schema in Parquet. > nit: Colon after JIRA Done Line 9: Having the repetition level set to REPEATED on the root schema > Yeah it would be good to reference the PARQUET JIRA. Well, IMPALA-4826 contains a link to the Parquet Jira (that explains why this should be ignored). I don't see the point of adding a reference to the commit msg as well. http://gerrit.cloudera.org:8080/#/c/7870/1/testdata/data/README File testdata/data/README: Line 111: Generated by hacking Impala's Parquet writer. > If it's just a one or two line change we could include the diff inline here Done: Added the repro steps here. -- To view, visit http://gerrit.cloudera.org:8080/7870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea84589e1d122ad9d43adde46893ec0ecc5f9c4 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
