Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7884/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: PS1, Line 184: In particular, partitioned hash joins under a union are : * treated as different series of joins (could have different data partitions). Can you expand the comment to explain what 'node' represents? Also, that part of the comment doesn't really help understanding this function and is similar to the comment in L178. Maybe remove? http://gerrit.cloudera.org:8080/#/c/7884/1/testdata/workloads/functional-query/queries/QueryTest/joins.test File testdata/workloads/functional-query/queries/QueryTest/joins.test: PS1, Line 761: nit: extra space -- To view, visit http://gerrit.cloudera.org:8080/7884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
