Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5850: Cast sender partition exprs under unions. ......................................................................
IMPALA-5850: Cast sender partition exprs under unions. For a series of partitioned joins within the same fragment we must cast the sender partition exprs of exchanges to compatible types. Otherwise, the hashes generated for identical partition values may differ among senders leading to wrong results. The bug was that this casting process was only performed for fragments that are hash-partitioned. However, a union produces a fragment with RANDOM partition, but the union could still contain partitioned joins whose senders need to be cast appropriately. The fix is to add casts regardless of the fragment's data partition. Testing: - Core/hdfs run passed - Added a new regresion test Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 Reviewed-on: http://gerrit.cloudera.org:8080/7884 Reviewed-by: Alex Behm <[email protected]> Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M testdata/workloads/functional-query/queries/QueryTest/joins.test 2 files changed, 82 insertions(+), 35 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0aa801bcad8c2324d848349c7967d949224404e0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Impala Public Jenkins
