Dan Hecht has posted comments on this change. Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan fragment's destinations ......................................................................
Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7760/5/common/thrift/StatestoreService.thrift File common/thrift/StatestoreService.thrift: PS5, Line 53: Impala service let's say "Impala internal service" just like you did for krpc_address to make it clear it's the same services. Or you could say ImpalaInternalService in both places, like you did in the other thrift file. -- To view, visit http://gerrit.cloudera.org:8080/7760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
