Michael Ho has posted comments on this change.

Change subject: IMPALA-4856, IMPALA-4872: Include KRPC services in plan 
fragment's destinations
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7760/4/common/thrift/StatestoreService.thrift
File common/thrift/StatestoreService.thrift:

Line 53:   // Network address of the Impala service on this backend
> specify that's the thrift address
Done


PS4, Line 73: svc_
> maybe just call it krpc_address for consistency e.g. address/krpc_address a
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8707bfb5028bbe81d2a042fcf3e6e19f4b719a72
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to