Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child types ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7922/1//COMMIT_MSG Commit Message: PS1, Line 22: compatibly typed col > compatible type? Done http://gerrit.cloudera.org:8080/#/c/7922/1/fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java File fe/src/main/java/org/apache/impala/analysis/KuduPartitionExpr.java: PS1, Line 76: children_.set( > wow, whoops... So in defense of the people who originally wrote and reviewed this code (i.e. you and me) the previous version works for the particular case I was thinking about of NullLiterals. The reason is that calling castTo on a NullLiteral doesn't create a new Expr, it just updates the NullLiteral's type field, so the 'set' is unnecessary. For most other Exprs, though, castTo creates a CastExpr to wrap the old expr. Somewhat poor interface design, but its of course still my fault for not catching it. We need an equivalent to WARN_UNUSED_RESULT for Java. -- To view, visit http://gerrit.cloudera.org:8080/7922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44cf31e46a77f3e7c92cf6b9112653808a001705 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
