Alex Behm has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull conditional. ......................................................................
Patch Set 5: * Correct! The BE code and all the associated function plumbing for IFNULL should be removed. * We should do the transformation even before analysis, like we do for NVL2 (see FunctionCallExpr#createExpr). I don't think we can get into a weird situation with NullLiterals. I like your idea of handling "[not] distinct from" in a separate rule. I agree that the docs are wrong, I'll let you decide whether to file a JIRA or fix it yourself. -- To view, visit http://gerrit.cloudera.org:8080/7829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id91ca968a0c0be44e1ec54ad8602f91a5cb2e0e5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-HasComments: No
