Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5211: Simplifying nullif conditional. ......................................................................
Patch Set 7: I should also mention that previous commit messages referred to "ifnull" where they should have referred to "nullif". It's not surprising that these are confusing, but it's worth noting that we didn't catch that in several rounds of reading. -- To view, visit http://gerrit.cloudera.org:8080/7829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id91ca968a0c0be44e1ec54ad8602f91a5cb2e0e5 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-HasComments: No