Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/8011/3//COMMIT_MSG Commit Message: Line 32: I tested this by running the repro from the JIRA and impalad did not > Do you think it's reasonable to turn this into an automated test? Would be Yes, it'd be nice to test this. I'd prefer a follow up, too. I filed IMPALA-5916 for this, it looks like a good onboarding task to me. http://gerrit.cloudera.org:8080/#/c/8011/3/be/src/exec/scanner-context.cc File be/src/exec/scanner-context.cc: Line 365: Status wrapped_status(TErrorCode::GENERAL_IO_ERROR); > Yeah I think there's some underlying issue with MergeStatus(). Not sure how Done. Status objects can only have a single message (msg_) and MergeStatus moves the argument's mgs_ into the details. Some places only log msg_ and not the full details, which then swallows the second msg_. http://gerrit.cloudera.org:8080/#/c/8011/4/be/src/exec/scanner-context.cc File be/src/exec/scanner-context.cc: Line 367: return wrapped_status; > I looked at the other errors coming from the I/O mgr. I don't think we shou Done -- To view, visit http://gerrit.cloudera.org:8080/8011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44dc95184c241fbcdbdbebad54339530680d3509 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
