Lars Volker has posted comments on this change. Change subject: IMPALA-5890: Abort queries if scanner hits IO errors ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/8011/6/be/src/runtime/disk-io-mgr-scan-range.cc File be/src/runtime/disk-io-mgr-scan-range.cc: Line 456: status = Status(GetHdfsErrorMsg("Error reading from HDFS file: ", file_)); > Missed this one. Done Line 468: status = Status(ss.str()); > Missed this one. Done Line 476: status = Status(GetHdfsErrorMsg("Error reading from HDFS file: ", file_)); > Missed this one. Done http://gerrit.cloudera.org:8080/#/c/8011/6/be/src/runtime/disk-io-mgr.cc File be/src/runtime/disk-io-mgr.cc: Line 544: return Status(Substitute("Invalid scan range. Bad disk id: $0", disk_id)); > We should treat these as non-recoverable too I think. Should we re-use DISK_IO_ERROR for those, even though they're technically not IO errors? Or should we create a new error code for them? Line 1167: ret_status = Status(ErrorMsg(TErrorCode::RUNTIME_ERROR, > Any reason not to change these too? Done -- To view, visit http://gerrit.cloudera.org:8080/8011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44dc95184c241fbcdbdbebad54339530680d3509 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
