Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3877: support unpatched LLVM ......................................................................
IMPALA-3877: support unpatched LLVM The p1 patch we use for LLVM avoided merging of structurally identical Struct types in unpredictable ways when linking in IR UDF modules. This avoided hitting type assertions when generating calls to IR UDfs. This implements an alternative solution, which is to bitcast the arguments when calling IR UDFs. This means we do not need to carry the patch when we upgrade LLVM. Testing: Ran core tests with unpatched LLVM 3.8, including the IR UDF test that originally required the patch to pass. Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d --- M be/src/codegen/CMakeLists.txt M be/src/codegen/codegen-anyval.cc A be/src/codegen/codegen-util.cc A be/src/codegen/codegen-util.h M be/src/codegen/llvm-codegen.h M be/src/exprs/expr-codegen-test.cc 6 files changed, 154 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/7973/2 -- To view, visit http://gerrit.cloudera.org:8080/7973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]>
