Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3877: support unpatched LLVM ......................................................................
IMPALA-3877: support unpatched LLVM The p1 patch we use for LLVM avoided merging of structurally identical Struct types in unpredictable ways when linking in IR UDF modules. This avoided hitting type assertions when generating calls to IR UDfs. This implements an alternative solution, which is to bitcast the arguments when calling IR UDFs. This means we do not need to carry the patch when we upgrade LLVM. Testing: Ran core tests with unpatched LLVM 3.8, including the IR UDF test that originally required the patch to pass. Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d Reviewed-on: http://gerrit.cloudera.org:8080/7973 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/codegen/CMakeLists.txt M be/src/codegen/codegen-anyval.cc A be/src/codegen/codegen-util.cc A be/src/codegen/codegen-util.h M be/src/codegen/llvm-codegen.h M be/src/exprs/expr-codegen-test.cc 6 files changed, 158 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/7973 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
