Tianyi Wang has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8047/1/be/src/service/fe-support.cc File be/src/service/fe-support.cc: Line 18: > what happened here? Sorry. Didn't notice it in diff. http://gerrit.cloudera.org:8080/#/c/8047/1/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 90: private final String outDir_ = System.getenv("IMPALA_FE_TEST_LOGS_DIR") > I suggest setting this in setUp() and checking whether the env var is set. Done -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
