Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3516: Avoid writing to /tmp in testing ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8047/3/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: Line 763: FileWriter fw = new FileWriter(outDir_ + testFile + ".test"); > There's a bug in this patch. A "/" is missing here between outDir_ and test I think its better to switch outDir_ to a "Path" type to avoid these kind of flaky stuff and use Path.toFile() wherever required. -- To view, visit http://gerrit.cloudera.org:8080/8047 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e503eb7d333c1b89dc8aea87cf30504838c44f9 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-HasComments: Yes
