Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7438/5/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: Line 203: RESULT_T result = value / multiplier; > Another idea: there are a finite number of possible delta_scale values. It After trying different approaches, this one produced the best results: http://github.mtv.cloudera.com/Taras/Impala/commit/950892a48e555ba24dcca772851d251ae3ecb17f Before: 66.13s After: 55.63s So, a small improvement. Still not that great: without the multiplication patch, it took 8.26s -- To view, visit http://gerrit.cloudera.org:8080/7438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37ad6232d7953bd75c18dc86e665b2b501a1ebe1 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zach Amsden <[email protected]> Gerrit-HasComments: Yes
