Dan Hecht has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8069/7/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: PS7, Line 85: DCHECK(!has_active_periodic_counters_); > #ifndef NDEBUG We shouldn't take locks only under debug builds since they have side effects (w.r.t. synchronization) and so can hide bugs from debug builds. -- To view, visit http://gerrit.cloudera.org:8080/8069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c39ac36c8e3c277213d32f5ae5f14be6b7f0df Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
