Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5895: clean up runtime profile lifecycle ......................................................................
Patch Set 9: Code-Review+1 (2 comments) LGTM, except these 2 comments. http://gerrit.cloudera.org:8080/#/c/8069/9/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: PS9, Line 368: PeriodicCounterUpdater::StopRateCounter(total_throughput_counter()); : PeriodicCounterUpdater::StopTimeSeriesCounter(bytes_read_timeseries_counter_); Spurious. These should be stopped in ScanNode::Close() ? http://gerrit.cloudera.org:8080/#/c/8069/9/be/src/runtime/data-stream-recvr.cc File be/src/runtime/data-stream-recvr.cc: PS9, Line 244: PeriodicCounterUpdater::StopTimeSeriesCounter( : recvr_->bytes_received_time_series_counter_); Seems like an outlier. -- To view, visit http://gerrit.cloudera.org:8080/8069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45c39ac36c8e3c277213d32f5ae5f14be6b7f0df Gerrit-PatchSet: 9 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
