Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 )
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7731/6/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/7731/6/be/src/statestore/statestore.cc@170 PS6, Line 170: total_value_size_bytes_ -= entry_it->second.value().size() also, does that still make sense (now that we no longer do the SetValue(NULL) at line 176 in the old code? -- To view, visit http://gerrit.cloudera.org:8080/7731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93cb7a033dc8f0d3e0339394b36affe14523274c Gerrit-Change-Number: 7731 Gerrit-PatchSet: 6 Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 21 Sep 2017 23:17:57 +0000 Gerrit-HasComments: Yes
