Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 )
Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ...................................................................... Patch Set 7: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7731/5/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/7731/5/be/src/statestore/statestore.cc@177 PS5, Line 177: Statestore::Subscriber::Subscriber(const SubscriberId& subscriber_id, : const TUniqueId& registration_id, const TNe > Hm, it's still not clear to me why a transient topic cannot get values in d okay. it wasn't clear to me if we can just take the value that was produced for an add/update and use it for delete, and expect that value to be the one that the subscriber expects for delete. But i guess assuming that is okay. -- To view, visit http://gerrit.cloudera.org:8080/7731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93cb7a033dc8f0d3e0339394b36affe14523274c Gerrit-Change-Number: 7731 Gerrit-PatchSet: 7 Gerrit-Owner: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2017 18:50:12 +0000 Gerrit-HasComments: Yes
