Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8084 )
Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8084/4/be/src/util/time-test.cc File be/src/util/time-test.cc: http://gerrit.cloudera.org:8080/#/c/8084/4/be/src/util/time-test.cc@85 PS4, Line 85: ); for debugging, it might be helpful to log the 'now_s' raw value in case of failure, which you can do use << on the EXPECT_EQ() -- To view, visit http://gerrit.cloudera.org:8080/8084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0ae06f6d94968c87a199625aa3332b26988142 Gerrit-Change-Number: 8084 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Sep 2017 23:26:02 +0000 Gerrit-HasComments: Yes
