Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8084 )
Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ...................................................................... Patch Set 6: (1 comment) Changed to C++ static_cast. http://gerrit.cloudera.org:8080/#/c/8084/6/be/src/util/time-test.cc File be/src/util/time-test.cc: http://gerrit.cloudera.org:8080/#/c/8084/6/be/src/util/time-test.cc@85 PS6, Line 85: (time_t *) > nit: per our style guide we use static_cast<> rather than C-style cast. sor Done -- To view, visit http://gerrit.cloudera.org:8080/8084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0ae06f6d94968c87a199625aa3332b26988142 Gerrit-Change-Number: 8084 Gerrit-PatchSet: 6 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Sep 2017 21:33:20 +0000 Gerrit-HasComments: Yes
