David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8102/5//COMMIT_MSG@12 PS5, Line 12: This commit continues previous work on IMPALA-5376 under the apache/incubator-impala repo : on github.com, and commit 6877 at gerrit.cloudera.org:8080. > Done Hope this isn't just me being a pest, but when I look at IMPALA-5376 on the Apache JIRA server, there's simply nothing there indicating that an initial patch (adding all of the missing tables) was earlier committed by Michael Ho. I prefer to have it explicitly stated this is a follow-on to that earlier patch. The last suggestion in this regard was to reference the first patch by its title, "IMPALA-5376: Loads all TPC-DS tables," rather than using a transient gerrit or github identifier. -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Comment-Date: Fri, 22 Sep 2017 21:58:21 +0000 Gerrit-HasComments: Yes
