Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 8: (1 comment) > Patch Set 6: > > (1 comment) > > > Job result output for PS 8 on jenkins.impala.io: > > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/329/consoleText > > This job is failing, yet I can't see why. Any ideas? I've determined that tests/run-tests.py exits non-zero when an expected-fail test is executed. This seems like wrong behavior from the framework. Instead, it should exit nonzero unless every test case behaves as expected. So when bugs behind xfail tests are fixed, those tests will pass, and fail the test run. That's a reminder to fix the expectation for that case in the test. I hestitate to include a framework fix like this in this ticket, because it will change the behavior of many tests. I can open a ticket on this though. http://gerrit.cloudera.org:8080/#/c/8102/6/testdata/workloads/tpcds/queries/tpcds-q47.test File testdata/workloads/tpcds/queries/tpcds-q47.test: http://gerrit.cloudera.org:8080/#/c/8102/6/testdata/workloads/tpcds/queries/tpcds-q47.test@10 PS6, Line 10: truncate(avg(sum(ss_sales_price)) over > Is there a bug tracking the flap? Done - Yes, IMPALA-5956. I've tagged all flapping tests with it to this point, and skipped them. -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2017 17:55:10 +0000 Gerrit-HasComments: Yes
