Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8084 )
Change subject: IMPALA-5599: Fix for mis-use of TimestampValue ...................................................................... IMPALA-5599: Fix for mis-use of TimestampValue The TimestampValue class is being used for non-database purposes in many places, such as in log messages. This change proposes to introduce APIs to convert Unix timetamps into the corresponding date-time strings. We provide a series of functions for different input time units, and also give the user control over the precision of the output date-time string. APIs are provided to format in UTC and local time zones. The new APIs can be used to replace (or instead of) TimestampValue::ToString() in those places where Unix timestamps are being converted to strings for printing. The current commit implements the APIs and replaces calls to TimestampValue::ToString() in be/src/service. A new unit test, time-test, has been added to the back-end tests. Other uses of TimestampValue in be/src/service, such as to track start and end times of queries, etc., will be analyzed and changed as appropriate in a follow-up commit. Change-Id: I9b0ae06f6d94968c87a199625aa3332b26988142 Reviewed-on: http://gerrit.cloudera.org:8080/8084 Reviewed-by: Dan Hecht <[email protected]> Tested-by: Impala Public Jenkins --- M be/src/service/impala-server.cc M be/src/util/CMakeLists.txt A be/src/util/time-test.cc M be/src/util/time.cc M be/src/util/time.h 5 files changed, 274 insertions(+), 13 deletions(-) Approvals: Dan Hecht: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9b0ae06f6d94968c87a199625aa3332b26988142 Gerrit-Change-Number: 8084 Gerrit-PatchSet: 8 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]>
