Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8102 )
Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala. ...................................................................... Patch Set 8: > Patch Set 6: > > Tim, can you provide more context for the observation that "run-tests.py > exits non-zero when an expected-fail test is executed?" We commonly have > XFAIL'ed tests that do not cause jobs to fail, e.g. from > https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/320/consoleFull > > 03:28:03 XFAIL > failure/test_failpoints.py::TestFailpoints::()::test_failpoints[table_format: > hbase/none | exec_option: {'batch_size': 0, 'num_nodes': 0, > 'disable_codegen_rows_threshold': 0, 'disable_codegen': False, > 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | mt_dop: 4 | > location: PREPARE | action: FAIL | query: select 1 from alltypessmall a join > alltypessmall b on a.id = b.id] > 03:28:03 reason: MT_DOP not supported. > 03:28:03 XFAIL > query_test/test_insert_behaviour.py::TestInsertBehaviour::()::test_insert_inherit_acls > 03:28:03 reason: [NOTRUN] Fails intermittently on test clusters > 03:28:03 =============== 1774 tests deselected by "-m 'execute_serially'" > =============== > 03:28:03 ===== 178 passed, 8 skipped, 1774 deselected, 4 xfailed in 1966.41 > seconds ===== I filed that based on my observation of running a single xfail test and getting a nonzero exit. Now I see the driver exits nonzero for a passing test as well, so time to poke around with the debugger. :| -- To view, visit http://gerrit.cloudera.org:8080/8102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66 Gerrit-Change-Number: 8102 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wood <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Matthew Mulder <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Wood <[email protected]> Gerrit-Comment-Date: Mon, 25 Sep 2017 18:24:28 +0000 Gerrit-HasComments: No
