Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8148 )
Change subject: IMPALA-4252: Move runtime filters to ScanNode ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.h File be/src/exec/scan-node.h: http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.h@195 PS1, Line 195: Scanner > Comment needs an update - this is no longer an argument. Done http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.h@198 PS1, Line 198: rs to arrive, check > Both HdfsScanNodeBase and KuduScanNodeBase have a "RuntimeState* runtime_st Done http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.cc File be/src/exec/scan-node.cc: http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.cc@79 PS1, Line 79: // TODO: Move this to Prepare() > Does this comment still make sense? I wish whoever added it had mentioned w Not sure, it was left by Michael (I'll ping him about it) in the review "Disentangle Expr and ExprContext" You asked about it during that review too, and his response was "I am thinking of moving it when PlanNode is introduced." but I'm not sure what that means. -- To view, visit http://gerrit.cloudera.org:8080/8148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17bdc869046dc2cd837d02f333441fa6324ff086 Gerrit-Change-Number: 8148 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2017 22:34:40 +0000 Gerrit-HasComments: Yes
