Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8148 )
Change subject: IMPALA-4252: Move runtime filters to ScanNode ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Makes sense to me. I think this is a pretty minor change so I think we can move this ahead. http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.cc File be/src/exec/scan-node.cc: http://gerrit.cloudera.org:8080/#/c/8148/1/be/src/exec/scan-node.cc@79 PS1, Line 79: // TODO: Move this to Prepare() > Not sure, it was left by Michael (I'll ping him about it) in the review "Di Ah I vaguely remember it now. We can just leave it for now I guess. -- To view, visit http://gerrit.cloudera.org:8080/8148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17bdc869046dc2cd837d02f333441fa6324ff086 Gerrit-Change-Number: 8148 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2017 23:15:06 +0000 Gerrit-HasComments: Yes